----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26578/#review56803 -----------------------------------------------------------
3rdparty/libprocess/include/process/gc.hpp <https://reviews.apache.org/r/26578/#comment97225> How about the include for unique ptr? 3rdparty/libprocess/include/process/gc.hpp <https://reviews.apache.org/r/26578/#comment97227> Let 'iter' spell out what it is for (and expand to a full word). - Niklas Nielsen On Oct. 13, 2014, 10:29 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26578/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 10:29 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Implement the finalize() virtual override for Libprocess' garbage collector. > This terminates all processes registered with the garbage collector when the > garbage collector terminates. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gc.hpp e83c636 > > Diff: https://reviews.apache.org/r/26578/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
