> On Oct. 16, 2014, 2:41 a.m., Vinod Kone wrote: > > bootstrap, line 15 > > <https://reviews.apache.org/r/26794/diff/1/?file=722835#file722835line15> > > > > Are you sure this symlink works? > > > > IIRC, it had to be > > > > ln -s ../../support/hooks/pre-commit .git/hooks/pre-commit
Apparently my hand testing failed me. Definitely does need to be ../../ Updated / fixed. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26794/#review56867 ----------------------------------------------------------- On Oct. 16, 2014, 4:30 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26794/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 4:30 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1932 > https://issues.apache.org/jira/browse/MESOS-1932 > > > Repository: mesos-git > > > Description > ------- > > Installs .gitignore and the mesos pre-commit hook if they aren't already set. > User-set hooks will never be overridden. > > > Diffs > ----- > > bootstrap 572755093f5a90115000f2829405462e3dd7accb > > Diff: https://reviews.apache.org/r/26794/diff/ > > > Testing > ------- > > Ran bootstrap by hand, verified that it created the files as desired, didn't > error when run more than once, and didn't override user-provided files. > > > Thanks, > > Cody Maloney > >
