----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56928 -----------------------------------------------------------
Ship it! Not sure what you mean by side-effects of dlclose on OSX. src/module/manager.cpp <https://reviews.apache.org/r/26789/#comment97374> I would love to see a note here that also warns others that removing a library from the dynamicLibraries-map would ultimately cause it to possibly get unloaded from memory. Such note may be rather verbose but given the trap lingering in this, I feel it might be worth it. src/module/manager.cpp <https://reviews.apache.org/r/26789/#comment97370> This sounds very temporarily almost like a TODO. - Till Toenshoff On Oct. 16, 2014, 3:12 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26789/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 3:12 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > Also removed the existing unloadAll() that is no longer needed. > > unloadAll() forces destruction of Owned pointers to the dynamic library > handle. This implicitly causes a dlclose() of all the loaded module > libraries. However, in certain situations (e.g. OS X), dlclose() is not > ideal due to its side-effects. > > > Diffs > ----- > > src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 > src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 > src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 > > Diff: https://reviews.apache.org/r/26789/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
