-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26798/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 5:17 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Update usage of apply-reviews.sh
Bugs: MESOS-1712 and MESOS-1932
https://issues.apache.org/jira/browse/MESOS-1712
https://issues.apache.org/jira/browse/MESOS-1932
Repository: mesos-git
Description
-------
With 26794 we install the git pre-commit hook on ./bootstrap. This means it
will be installed on the buildbot automatically when that review is tested.
This updates verify-reviews.py to depend on that behavior to get style checking
(As well as any other checking we add). It makes verify-reviews.py use
support/apply-reviews.sh to apply the reviewboad review (As commiters generally
should when applying review requests), to grab the diff from reviewboard and
apply it.
Diffs (updated)
-----
support/apply-review.sh 75ac842c526eeabffef162ade28373f911b668e8
support/verify-reviews.py 9408747995db4b78ac6edd74995a05ab0355f1df
Diff: https://reviews.apache.org/r/26798/diff/
Testing
-------
Ran ./support/verify-reviews.py by hand, commenting out the body of
post_reviews, as well as the distcheck step.
I committed the commenting out locally so it wouldn't get undone with the 'git
reset' was executed.
Thanks,
Cody Maloney
