> On Oct. 16, 2014, 2:23 p.m., Niklas Nielsen wrote: > > src/master/flags.hpp, lines 313-315 > > <https://reviews.apache.org/r/26674/diff/2/?file=722701#file722701line313> > > > > Thanks for clarifying! The order of the paragraphs seems a bit off > > though: First the json file, then the caveat on file and name, then in-line > > json. Does it maybe belong after the example blob?
Since this protobuf/json is growing, the explanation should be moved to a document with a reference to that document in the command-line help. I have created a JIRA for that (https://issues.apache.org/jira/browse/MESOS-1937). > On Oct. 16, 2014, 2:23 p.m., Niklas Nielsen wrote: > > src/tests/module_tests.cpp, lines 145-146 > > <https://reviews.apache.org/r/26674/diff/2/?file=722706#file722706line145> > > > > Needs to be updated to unload() right? This is handled by a separate patch. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/#review56854 ----------------------------------------------------------- On Oct. 15, 2014, 9:57 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26674/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 9:57 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > To allow the users to specify a bare library names. > > For example, "foo-2.3" will expand to "libfoo-2.3.so" on Linux and > "libfoo-2.3.dylib" on OS X. > > > Diffs > ----- > > src/master/flags.hpp c41af1f4b1671d121eb617327086f5d80a2ba083 > src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99 > src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 > src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 > src/slave/flags.hpp 159d4ef63643d17be353533992049a38aec72437 > src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 > > Diff: https://reviews.apache.org/r/26674/diff/ > > > Testing > ------- > > Added a new test and ran make check. > > > Thanks, > > Kapil Arya > >
