----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26843/#review57050 -----------------------------------------------------------
Ship it! Ah, much nicer, thanks Jie! 3rdparty/libprocess/3rdparty/stout/include/stout/os/fcntl.hpp <https://reviews.apache.org/r/26843/#comment97524> Any TODO you can think of to avoid needing to deal with multiple calls to fcntl? 3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp <https://reviews.apache.org/r/26843/#comment97525> Remove this? - Ben Mahler On Oct. 16, 2014, 11:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26843/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 11:29 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Pulled open/close/fcntl to separate files. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > d4a8ad4e776bcfe1f008e561b5a92340f4d84bd9 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > c26bd2af4f5abb552645049ce097af2968829aac > 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fcntl.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26843/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
