----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review57113 -----------------------------------------------------------
Bad patch! Reviews applied: [26610, 26861, 26862] Failed command: ./support/apply-review.sh -n -r 26862 Error: --2014-10-17 06:30:45-- https://reviews.apache.org/r/26862/diff/raw/ Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74 Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 40958 (40K) [text/x-patch] Saving to: '26862.patch' 0K .......... .......... .......... ......... 100% 605K=0.07s 2014-10-17 06:30:45 (605 KB/s) - '26862.patch' saved [40958/40958] Successfully applied: Fix docker flaky tests Docker tests are flaky, mostly around getting expected output from the docker container forwarded to stdout/stderr. This is due to Docker not always have the stdout/stderr output available for docker logs if kill/rm is called. Review: https://reviews.apache.org/r/26862 Checking 7 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo src/tests/docker_containerizer_tests.cpp:200: Lines should be <= 80 characters long [whitespace/line_length] [2] Total errors found: 1 Failed to commit patch - Mesos ReviewBot On Oct. 17, 2014, 5:30 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26862/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 5:30 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Docker tests are flaky, mostly around getting expected output from the docker > container forwarded to stdout/stderr. > > This is due to Docker not always have the stdout/stderr output available for > docker logs if kill/rm is called. > > > Diffs > ----- > > src/docker/docker.hpp 9656f15 > src/docker/docker.cpp e09b51c > src/slave/containerizer/docker.hpp fbbd45d > src/slave/containerizer/docker.cpp 9a29489 > src/tests/docker_containerizer_tests.cpp 67d60a8 > src/tests/docker_tests.cpp 04139af > src/tests/environment.cpp 4dd78e7 > > Diff: https://reviews.apache.org/r/26862/diff/ > > > Testing > ------- > > make with gtest_repeat=-1 gtest_shuffle=1 > > > Thanks, > > Timothy Chen > >
