----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57166 -----------------------------------------------------------
src/tests/module_tests.hpp <https://reviews.apache.org/r/26855/#comment97701> A lot of things are going on in the setup and tear down. Can you add comments here and below on the invariants? src/tests/module_tests.hpp <https://reviews.apache.org/r/26855/#comment97696> The indentation seems off here. src/tests/module_tests.hpp <https://reviews.apache.org/r/26855/#comment97716> I got ' ../../src/tests/module_tests.hpp:52: Failure dynamicLibrary.open( ModuleManager::expandLibraryName(defaultLibraryName())): Library already opened' when running this: you should only call open() once src/tests/module_tests.hpp <https://reviews.apache.org/r/26855/#comment97713> Mind expanding 'orig' to a full word? Another thought; can we have these hang off the ModuleTest object instead of being statics? src/tests/module_tests.hpp <https://reviews.apache.org/r/26855/#comment97708> expand 'dir' please src/tests/module_tests.hpp <https://reviews.apache.org/r/26855/#comment97707> Can we use modules.size() instead of the extra initialized variables? Also, does modules need to be static? src/tests/module_tests.cpp <https://reviews.apache.org/r/26855/#comment97712> Missed this one before. Mind adding a comment here for the test? src/tests/module_tests.cpp <https://reviews.apache.org/r/26855/#comment97699> Can we make the Modules object const? Here and below? - Niklas Nielsen On Oct. 16, 2014, 11:11 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26855/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 11:11 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > During the one-time setup of the test cases, we do the following: > 1. set LD_LIBRARY_PATH to also point to the src/.libs directory. > The original LD_LIBRARY_PATH is restored at the end of all tests. > 2. dlopen() examplemodule library and retrieve the pointer to > ModuleBase for the test module. This pointer is later used to > reset the Mesos and module API versions during per-test teardown. > > During the tear-down after each test, we unload the module to allow > later loads to succeed. > > > Diffs > ----- > > src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 > src/examples/example_module_impl.cpp > 27c05201a53de3efb00846e694db41cfe9250e61 > src/tests/module_tests.hpp PRE-CREATION > src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 > > Diff: https://reviews.apache.org/r/26855/diff/ > > > Testing > ------- > > make check with and without shuffle with repeated iterations. > > > Thanks, > > Kapil Arya > >
