----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/#review57202 -----------------------------------------------------------
Hm.. could you please split the code movement out into a separate change so that it's easier to see what you're changing here? Hard to see what's changed inside within the continuation since it's been moved as well. - Ben Mahler On Oct. 17, 2014, 7:53 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26817/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 7:53 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > split authorization from task validation. allows > https://reviews.apache.org/r/26382/ to differentiate between validation > issues and task authorization issues. > > also replaced some > > with >> and changed the order of methods in the cpp to > match the continuation order. > > > Diffs > ----- > > src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205 > src/master/master.cpp 1b1ce0de3065ced45890777d42c69ef1091f5699 > > Diff: https://reviews.apache.org/r/26817/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
