----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/#review57213 -----------------------------------------------------------
Hey Cody, just took a quick look at this, had a few high level questions below. 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp <https://reviews.apache.org/r/26766/#comment97751> Hm.. what is asAbsolute doing? I would have expected this to be equivalent to `realpath()` from the signature name. That is, convert a relative path to an absolute path. However, this just prepends a slash? Seems like a fairly arbitrary path manipulation? 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp <https://reviews.apache.org/r/26766/#comment97753> This confuses me since it appears to be an identity function at first glance. For comparision, imagine if I was reading the following very similar identity function: ``` // Returns exactly what you pass in. string identity(s) { return strings::join(",", strings::split(",", s)); } ``` Do we have the right abstractions here? - Ben Mahler On Oct. 16, 2014, 8:53 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26766/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 8:53 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Bugs: MESOS-1878 > https://issues.apache.org/jira/browse/MESOS-1878 > > > Repository: mesos-git > > > Description > ------- > > Adds 3 new functions: asAbsolute, clean, and split(). All three were > hand-coded inside of mesos files (files/files.cpp). This puts them in a > common place, and adds unit tests for their behavior. > > The functions depend on eachother somewhat, so I pulled out the declarations > to make them all forward declared. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > 357a75a8bac497465671456aa9cd9181123cc635 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp > aedf93573ea89e46bf7b7b91f2258049af2fd79f > > Diff: https://reviews.apache.org/r/26766/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Cody Maloney > >
