> On Oct. 17, 2014, 11:02 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [26736] > > > > Failed command: ./support/apply-review.sh -n -r 26736 > > > > Error: > > --2014-10-17 23:02:08-- https://reviews.apache.org/r/26736/diff/raw/ > > Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74 > > Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... > > connected. > > HTTP request sent, awaiting response... 200 OK > > Length: 6047 (5.9K) [text/x-patch] > > Saving to: '26736.patch' > > > > 0K ..... 100% 182M=0s > > > > 2014-10-17 23:02:08 (182 MB/s) - '26736.patch' saved [6047/6047] > > > > Successfully applied: Ensure docker calls stop if a docker_stop_timeout is > > provided Added the flag docker_stop_timeout that defaults to 0, if the > > timeout is 0 the a docker kill will be run, otherwise a docker stop with > > the timeout in seconds is used. A negative value will result in a Failure. > > > > Ensure docker calls stop if a docker\_stop\_timeout is provided Added the > > flag docker\_stop\_timeout that defaults to 0, if the timeout is 0 the a > > docker kill will be run, otherwise a docker stop with the timeout in > > seconds is used. A negative value will result in a Failure. > > > > > > Review: https://reviews.apache.org/r/26736 > > Checking 6 files using filter > > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo > > src/docker/docker.cpp:475: Lines should be <= 80 characters long > > [whitespace/line_length] [2] > > Total errors found: 1 > > Failed to commit patch
Darn checkstyle. Maybe that should be a part of the commit hook or `make check`. - Ankur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review57237 ----------------------------------------------------------- On Oct. 17, 2014, 9:55 p.m., Ryan Thomas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26736/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 9:55 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1925 > https://issues.apache.org/jira/browse/MESOS-1925 > > > Repository: mesos-git > > > Description > ------- > > Ensure docker calls stop if a docker_stop_timeout is provided Added the flag > docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill > will be run, otherwise a docker stop with the timeout in seconds is used. A > negative value will result in a Failure. > > > Diffs > ----- > > src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a > src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2 > src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 > src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1 > src/tests/docker_containerizer_tests.cpp > 67d60a885d65edbcbbf702bce83a54d1a5c0411f > src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba > > Diff: https://reviews.apache.org/r/26736/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose > support/mesos-style.py > > > Thanks, > > Ryan Thomas > >
