> On Oct. 16, 2014, 6:24 p.m., Niklas Nielsen wrote: > > src/tests/isolator_tests.cpp, lines 129-130 > > <https://reviews.apache.org/r/26071/diff/6/?file=723152#file723152line129> > > > > Don't know if we have any specific wrapping rules wrt very long > > templates. This looks off to me - but let's look into that.
I have left it as is for now. Let's figure out a better way. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57013 ----------------------------------------------------------- On Oct. 18, 2014, 3:10 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26071/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2014, 3:10 p.m.) > > > Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. > These modules are also hooked up to the relevant Isolator tests using the > typed test mechanism. It also paves the way for future integration with > custom modules specified on the command line. > > > Diffs > ----- > > src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 > src/examples/test_isolator_module.cpp PRE-CREATION > src/module/isolator.hpp PRE-CREATION > src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d > src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 > src/tests/module.hpp PRE-CREATION > src/tests/module.cpp PRE-CREATION > src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 > > Diff: https://reviews.apache.org/r/26071/diff/ > > > Testing > ------- > > make check with an Isolator module test. > > > Thanks, > > Kapil Arya > >
