----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26929/#review57396 -----------------------------------------------------------
Patch looks great! Reviews applied: [26929] All tests passed. - Mesos ReviewBot On Oct. 20, 2014, 2:41 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26929/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 2:41 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1945 > https://issues.apache.org/jira/browse/MESOS-1945 > > > Repository: mesos-git > > > Description > ------- > > Moving EXPECT_CALL(removeFramework) before killTask() removes a race, which > made the expected call occur before it is expected. > > > Diffs > ----- > > src/tests/slave_tests.cpp 0ded545b4cc7dfa2989d072d74ab5b1d7a2a8b9c > > Diff: https://reviews.apache.org/r/26929/diff/ > > > Testing > ------- > > Reenabled the test, make check. > > > Thanks, > > Bernd Mathiske > >
