> On Oct. 17, 2014, 6:58 p.m., Ben Mahler wrote: > > src/messages/messages.proto, line 55 > > <https://reviews.apache.org/r/26699/diff/3/?file=723857#file723857line55> > > > > Wonder if it's time for a UUID wrapper message type akin to what we did > > with all of our _ID types.. > > > > Just putting it out there as potential TODO material. :)
great idea. added TODO. > On Oct. 17, 2014, 6:58 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 2357-2361 > > <https://reviews.apache.org/r/26699/diff/3/?file=723858#file723858line2357> > > > > Could you add a little comment about where we're looking here? In > > particular, why queued tasks and completed tasks are ignored. > > > > Or, should there be a CHECK for no queued task matching this? Added a comment. Can't do a CHECK because updates are sent by executors. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/#review57185 ----------------------------------------------------------- On Oct. 17, 2014, 12:26 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26699/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 12:26 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Slave re-registration now sends both the latest state and unacknowledged > state to the master. > > > Diffs > ----- > > src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99 > src/slave/slave.cpp 0e342ed35e3db3b68f9f32b6cf4ace23e4a4db38 > src/tests/fault_tolerance_tests.cpp > a75910d4f486230ba3f1d8927e5f1e5fda6e287b > src/tests/slave_tests.cpp f585bdd20ae1af466f2c1b4d85331ac67451552f > > Diff: https://reviews.apache.org/r/26699/diff/ > > > Testing > ------- > > make check > > Ran new test 1000 times. > > > Thanks, > > Vinod Kone > >
