> On Oct. 22, 2014, 12:19 p.m., Niklas Nielsen wrote: > > src/module/manager.cpp, line 31 > > <https://reviews.apache.org/r/27020/diff/1/?file=728584#file728584line31> > > > > Do you know why you didn't need this include before?
Because we were including manager.hpp which includes this file. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27020/#review57807 ----------------------------------------------------------- On Oct. 22, 2014, 1:54 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27020/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 1:54 a.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-1965 > https://issues.apache.org/jira/browse/MESOS-1965 > > > Repository: mesos-git > > > Description > ------- > > Created mesos::modules namespace for all module related stuff. > > > Diffs > ----- > > include/mesos/module.hpp 5205e30c7b8228eced9793aef2348930180811bb > src/examples/example_module_impl.cpp > 169453aaebe02ef1432beb59838077bb28a0df6e > src/examples/test_module.hpp b5cc2fa9147c4fe9a1f2eb3e8c2c2565ea7f7420 > src/master/main.cpp 29ded49f5c18b12dbe4ff9b69ee3343c04ce2cf8 > src/module/manager.hpp 1c93ac4707e3c5dc8acaaa23861b62d3d3921125 > src/module/manager.cpp 105e5afd5b49e907380389f6020a7f6d5e732b3f > src/slave/main.cpp b27cc32ebccb1c97f2f2ae0b904c725bbf541ebf > src/tests/module_tests.cpp e92d8717427e259b1fa26b3f17719fd616a748c7 > > Diff: https://reviews.apache.org/r/27020/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
