----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26990/#review57908 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/26990/#comment98804> s/slave/slaveState/ src/slave/state.cpp <https://reviews.apache.org/r/26990/#comment98809> Why not just move this up above the reboot check? That way you no need to change much else in this method. - Vinod Kone On Oct. 21, 2014, 7:43 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26990/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 7:43 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1902 > https://issues.apache.org/jira/browse/MESOS-1902 > > > Repository: mesos-git > > > Description > ------- > > See summary. This is the first step to support persistent disk resources. > This patch allows us to checkpoint resources which is not part of the slave > life cycle. > > > Diffs > ----- > > src/slave/paths.hpp 41bb73d6359ee6122ccc2170512311e1ad4fcc4c > src/slave/slave.hpp 342b09fc084c20d98d096bb129830440179c092c > src/slave/slave.cpp 0e342ed35e3db3b68f9f32b6cf4ace23e4a4db38 > src/slave/state.hpp 22f569def3c000856190deff4d55e636afb9e00e > src/slave/state.cpp 87e9eb958d1af4e6742f1eed7fe90fedb16b07a7 > src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33 > > Diff: https://reviews.apache.org/r/26990/diff/ > > > Testing > ------- > > make check > > Will add some unit test soon. > > > Thanks, > > Jie Yu > >
