----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20423/#review58067 -----------------------------------------------------------
Bad patch! Reviews applied: [20423] Failed command: ./support/apply-review.sh -n -r 20423 Error: --2014-10-23 19:35:19-- https://reviews.apache.org/r/20423/diff/raw/ Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74 Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 31756 (31K) [text/x-patch] Saving to: '20423.patch' 0K .......... .......... .......... . 100% 970K=0.03s 2014-10-23 19:35:20 (970 KB/s) - '20423.patch' saved [31756/31756] 20423.patch:819: new blank line at EOF. + warning: 1 line adds whitespace errors. Successfully applied: Moved validation visitors out of master.cpp. This is the first step toward being able to write independent unit tests for the validation visitors. It also uses Owned to make visitor cleanup simpler (non-existent). Review: https://reviews.apache.org/r/20423 src/master/taskinfovisitor.hpp:177: new blank line at EOF. Failed to commit patch - Mesos ReviewBot On Oct. 23, 2014, 5:51 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20423/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 5:51 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1064 > https://issues.apache.org/jira/browse/MESOS-1064 > > > Repository: mesos-git > > > Description > ------- > > This is the first step toward being able to write independent unit tests for > the validation visitors. > > It also uses Owned to make visitor cleanup simpler (non-existent). > > > Diffs > ----- > > src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 > src/master/master.cpp 95589b8f25a3e496eabc0cf84319c883c1ed7aec > src/master/offervisitor.hpp PRE-CREATION > src/master/offervisitor.cpp PRE-CREATION > src/master/taskinfovisitor.hpp PRE-CREATION > src/master/taskinfovisitor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20423/diff/ > > > Testing > ------- > > make check. > ran Java test framework. > > > Thanks, > > Dominic Hamon > >
