> On Oct. 22, 2014, 6:54 p.m., Vinod Kone wrote: > > src/tests/mesos.cpp, line 108 > > <https://reviews.apache.org/r/26860/diff/1/?file=724050#file724050line108> > > > > why is this called "authenticator" insstead of "authentication"? > > > > also, what's the naming convention. for modules that live in source > > tree we have "org_apache_mesos" prefix? and for modules outside source tree > > they would look like something like "com_companyname_mesos"? sorry i > > haven't been following the modules patches too closely.
> why is this called "authenticator" insstead of "authentication"? The module itself is implementing the Authenticator interface. The module library however will combine both, Authenticator and Authenticatee -- the latter in a subsequent patch (after the 0.21 cut). > also, what's the naming convention. for modules that live in source tree we > have "org_apache_mesos" prefix? and for modules outside source tree they > would look like something like "com_companyname_mesos"? sorry i haven't been > following the modules patches too closely. Yes, you pretty much nailed it :). The upcoming module developers guide will clearify that. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26860/#review57860 ----------------------------------------------------------- On Oct. 17, 2014, 4:08 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26860/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 4:08 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > The CRAM-MD5 authenticator module is integrated into all authentication > enabled tests (slave and framework). > > > Diffs > ----- > > src/Makefile.am c44a9ad > src/tests/cluster.hpp ee194ad > src/tests/crammd5_authenticator_tests.cpp PRE-CREATION > src/tests/mesos.cpp 3dcb2ac > src/tests/sasl_tests.cpp 30556fa > src/tests/script.cpp 515e314 > > Diff: https://reviews.apache.org/r/26860/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
