----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review58315 -----------------------------------------------------------
As discussed on IRC: --> please split this into multiple reviews (attributes methods and tests, compatible method, allocator changes, rest) --> fold slaveinfo_utils into protobuf_utils --> rethink reregisterSlave() (i'll help with this). one optimization i can think of which might help make reregisterSlave() simpler is to update the registrar to not do a log write if there is no mutation (e.g., readmit slave). It's fine if it seems too complicated and you want to punt on it too. - Vinod Kone On Oct. 22, 2014, 12:32 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25525/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 12:32 a.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos-git > > > Description > ------- > > Allows attributes and resources to be set to a superset of what they were > previously on a slave restart. > > Incorporates all comments from: > https://issues.apache.org/jira/browse/MESOS-1739 > and the former review request: > https://reviews.apache.org/r/25111/ > > > Diffs > ----- > > src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 > src/common/attributes.hpp 0a043d5b5dca804c6dd215cabd2704f24df71a33 > src/common/attributes.cpp aab114e1a5932e3f218b850e1afc7f2ef0f10e21 > src/common/slaveinfo_utils.hpp PRE-CREATION > src/common/slaveinfo_utils.cpp PRE-CREATION > src/master/allocator.hpp 02d20d0cc802805bc702891306aa42894531b223 > src/master/hierarchical_allocator_process.hpp > 31dfb2cc86e2e74da43f05fbada10976ce65f3e4 > src/master/master.hpp b1a2cd0f51f89d6dabbccaa67e0411fc55a4272f > src/master/master.cpp e70cdbf78fd79738d38ecf314f9d8ee207558db2 > src/slave/slave.cpp 55e5264a61ce43970e177cf0eb27dc8a2657e261 > src/tests/attributes_tests.cpp 240a8cac18ac12178cf73e8eeb88bd50e3fcc03b > src/tests/mesos.hpp e36e13843a36360d69a01f62356370bea588a337 > src/tests/slave_tests.cpp a1bd00cffe9de178b0b188c3556e479cd1f6d566 > > Diff: https://reviews.apache.org/r/25525/diff/ > > > Testing > ------- > > make check on localhost > > > Thanks, > > Cody Maloney > >
