----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27150/#review58329 -----------------------------------------------------------
Ship it! src/common/type_utils.hpp <https://reviews.apache.org/r/27150/#comment99281> Why did you wrap all the ones above but not this one? - Ben Mahler On Oct. 24, 2014, 6:22 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27150/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 6:22 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > I've reordered the functions (grouped by operator type, sorted by alphebet, > moved non-trivial functions to cpp file). I haven't changed any content. > > Also, I added a equal comparator for Volume. > > > Diffs > ----- > > src/common/type_utils.hpp f10b2d31f2781bd056898f93eb8e8b6d9809e80b > src/common/type_utils.cpp 4f8d6ec912a41d11f16970ef7bbfa72bcbef8e8b > > Diff: https://reviews.apache.org/r/27150/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
