----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27165/#review58441 -----------------------------------------------------------
Ship it! src/linux/ns.hpp <https://reviews.apache.org/r/27165/#comment99446> Can you hide this in an internal namespace? This can just return Nothing directly. src/linux/ns.hpp <https://reviews.apache.org/r/27165/#comment99451> Can you move this above the call to getns? src/tests/ns_tests.cpp <https://reviews.apache.org/r/27165/#comment99459> children src/tests/ns_tests.cpp <https://reviews.apache.org/r/27165/#comment99461> Can we use ROOT? - Ben Mahler On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27165/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 9:54 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > All processes are signalled with SIGKILL then reaped. The order of > signalling is not determined, i.e., generally the init pid is not the > first pid signalled. > > > Diffs > ----- > > src/linux/ns.hpp PRE-CREATION > src/tests/ns_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/27165/diff/ > > > Testing > ------- > > make check # new test added > > > Thanks, > > Ian Downes > >
