> On Oct. 26, 2014, 5:58 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp, line 43 > > <https://reviews.apache.org/r/24535/diff/4/?file=733453#file733453line43> > > > > "since"
Thanks. > On Oct. 26, 2014, 5:58 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp, line 39 > > <https://reviews.apache.org/r/24535/diff/4/?file=733453#file733453line39> > > > > Should this be in an internal namespace? Otherwise, callers might think > > they need to call initialize before the other functions? I decided to put it in the public namespace in case someone actually did have another APR library that they're using and wants to serialize the initialization of APR by initializing both libraries before starting to do things in a multi-threaded capacity. It seemed cleaner to have people call svn::initialize than svn::diff("", "") or something similar. Nevertheless, I added a note explaining why this function was exposed. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/#review58564 ----------------------------------------------------------- On Oct. 25, 2014, 11:18 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24535/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 11:18 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Note that this hard codes the location of the subversion and Apache Portable > Runtime (APR) headers. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 1e24886628d07a788385e5056f05869b373d970a > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 41360620ee28bd2fca50f4b57ebe5803b10437cf > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > d5290130a5864aa38dc6aadb0d9664efb1424488 > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/24535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
