Why not: if >= 1.8 svn_txdelta_to_svndiff3 else if >= 1.7 svn_txdelta_to_svndiff2 else svn_txdelta_to_svndiff
On Mon, Oct 27, 2014 at 4:57 PM, Timothy Chen <[email protected]> wrote: > I don't think there is any harm, but I tihnk we need to have a default > diff method that we choose to use, and if it's not svndiff2 (by > checking for 1.4) then I'm not sure what that is. > > Tim > > > On Mon, Oct 27, 2014 at 4:14 PM, Benjamin Mahler > <[email protected]> wrote: > > What's the harm? We pass 0 anyway for the version argument, > > which svn_txdelta_to_svndiff2 is making explicit. > > > > On Mon, Oct 27, 2014 at 4:13 PM, Timothy Chen <[email protected]> > wrote: > > > >> > >> > >> > On Oct. 27, 2014, 11:07 p.m., Ben Mahler wrote: > >> > > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp, line 116 > >> > > < > >> > https://reviews.apache.org/r/27243/diff/3/?file=734653#file734653line116> > >> > > > >> > > svn_txdelta_to_svndiff3 was introduced in 1.7 > >> > > svn_txdelta_to_svndiff2 was introduced in 1.4 > >> > >> I don't think I'll be checking for 1.4, since we should expect a certain > >> minimum version installed already. > >> > >> > >> - Timothy > >> > >> > >> ----------------------------------------------------------- > >> This is an automatically generated e-mail. To reply, visit: > >> https://reviews.apache.org/r/27243/#review58715 > >> ----------------------------------------------------------- > >> > >> > >> On Oct. 27, 2014, 10:21 p.m., Timothy Chen wrote: > >> > > >> > ----------------------------------------------------------- > >> > This is an automatically generated e-mail. To reply, visit: > >> > https://reviews.apache.org/r/27243/ > >> > ----------------------------------------------------------- > >> > > >> > (Updated Oct. 27, 2014, 10:21 p.m.) > >> > > >> > > >> > Review request for mesos and Benjamin Hindman. > >> > > >> > > >> > Repository: mesos-git > >> > > >> > > >> > Description > >> > ------- > >> > > >> > Review: https://reviews.apache.org/r/27243 > >> > > >> > > >> > Diffs > >> > ----- > >> > > >> > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp > >> 117ab0a662bfe2d2b1ec8fa64c6d57bdf1b0004a > >> > > >> > Diff: https://reviews.apache.org/r/27243/diff/ > >> > > >> > > >> > Testing > >> > ------- > >> > > >> > make check > >> > > >> > > >> > Thanks, > >> > > >> > Timothy Chen > >> > > >> > > >> > >> >
