> On Oct. 30, 2014, 12:15 a.m., Adam B wrote: > > src/authentication/cram_md5/authenticator.hpp, line 537 > > <https://reviews.apache.org/r/26857/diff/7/?file=740321#file740321line537> > > > > CHECK_NOTNULL
CHECK_NOTNULL does not allow for any helpful messages, hence I chose CHECK instead. > On Oct. 30, 2014, 12:15 a.m., Adam B wrote: > > src/module/manager.cpp, lines 60-62 > > <https://reviews.apache.org/r/26857/diff/7/?file=740324#file740324line60> > > > > Maybe these should be alphabetized, to make it easier to find modules > > as this list grows. Aye, makes sense. > On Oct. 30, 2014, 12:15 a.m., Adam B wrote: > > src/authentication/cram_md5/authenticator.hpp, line 84 > > <https://reviews.apache.org/r/26857/diff/7/?file=740321#file740321line84> > > > > s/authenticator/crammd5_authenticator/ in case we end up with multiple > > authenticator process types (+kerberos) running simultaneously Good point. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 ----------------------------------------------------------- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26857/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 6:51 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Introducing the CRAM-MD5 SASL authenticator module based on the former > sasl/authenticator. > > The former sasl/authenticator.hpp still remains as part of libmesos but now > is located at authentication/cram_md5. > > > Diffs > ----- > > src/Makefile.am f177d87 > src/authentication/authenticator.hpp PRE-CREATION > src/authentication/cram_md5/authenticator.hpp PRE-CREATION > src/examples/test_authenticator_module.cpp PRE-CREATION > src/module/authenticator.hpp PRE-CREATION > src/module/manager.cpp 7a6c884 > > Diff: https://reviews.apache.org/r/26857/diff/ > > > Testing > ------- > > make check > > NOTE all four CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
