----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27447/#review59423 -----------------------------------------------------------
Patch looks great! Reviews applied: [27446, 27447] All tests passed. - Mesos ReviewBot On Oct. 31, 2014, 8:29 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27447/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 8:29 p.m.) > > > Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched > to 'mcypark'. > > > Bugs: MESOS-2019 > https://issues.apache.org/jira/browse/MESOS-2019 > > > Repository: mesos-git > > > Description > ------- > > The Node class abstracts the endpoint notion: it defines the association of > the ip and port for a connection. A node defines more the host(which can have > multiple active endpoints). > At the moment, the Node class is used to keep a mapping from a socket to the > ip & port pair in the process namespace. > I want to propose to rename this class in Endpoint and also extend its use by > replacing the ip & port fields from the UPID class and process namespace with > this type. > > > Diffs > ----- > > src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019 > src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd > src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 > src/scheduler/scheduler.cpp fb88a3e029e97ba33eae5d50503be5ed9c9533e6 > src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d > src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644 > src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451 > src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346 > src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5 > src/tests/master_contender_detector_tests.cpp > 8f7fb18f0ca985364565fc4cd50f113b1461fbe7 > src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6 > src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d > > Diff: https://reviews.apache.org/r/27447/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
