-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 4:59 p.m.)
Review request for mesos, Tobias Weingartner and Vinod Kone.
Changes
-------
add slave and limit to explicit metrics.
Summary (updated)
-----------------
Update Master and Slave metrics to match task source and reason scheme.
Bugs: MESOS-1830
https://issues.apache.org/jira/browse/MESOS-1830
Repository: mesos-git
Description
-------
Update metrics in Master to match the source and reason split for task statuses.
Diffs (updated)
-----
src/master/master.hpp b1a2cd0f51f89d6dabbccaa67e0411fc55a4272f
src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd
src/slave/slave.hpp eb5de736ba63dfab5bf048d7a09462f0cff9aaea
src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644
src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6
src/tests/slave_tests.cpp a1bd00cffe9de178b0b188c3556e479cd1f6d566
Diff: https://reviews.apache.org/r/27531/diff/
Testing (updated)
-------
make check
run master and check endpoint:
{
...
master/reconciliation_states/task_error: 0,
master/reconciliation_states/task_failed: 0,
master/reconciliation_states/task_finished: 0,
master/reconciliation_states/task_killed: 0,
master/reconciliation_states/task_lost: 0,
master/reconciliation_states/task_running: 0,
master/reconciliation_states/task_staging: 0,
master/reconciliation_states/task_starting: 0,
master/recovery_slave_removals: 0,
master/slave_registrations: 1,
master/slave_removals: 0,
master/slave_reregistrations: 0,
master/slaves_active: 1,
master/slaves_connected: 1,
master/slaves_disconnected: 0,
master/slaves_inactive: 0,
master/tasks_failed: 0,
master/tasks_finished: 0,
master/tasks_killed: 0,
master/tasks_lost: 0,
master/tasks_lost/reason_executor_terminated: 0,
master/tasks_lost/reason_executor_unregistered: 0,
master/tasks_lost/reason_framework_removed: 0,
master/tasks_lost/reason_gc_error: 0,
master/tasks_lost/reason_invalid_command: 0,
master/tasks_lost/reason_invalid_frameworkid: 0,
master/tasks_lost/reason_invalid_offers: 0,
master/tasks_lost/reason_master_disconnected: 0,
master/tasks_lost/reason_memory_limit: 0,
master/tasks_lost/reason_reconciliation: 0,
master/tasks_lost/reason_slave_disconnected: 0,
master/tasks_lost/reason_slave_removed: 0,
master/tasks_lost/reason_slave_restarted: 0,
master/tasks_lost/reason_slave_unknown: 0,
master/tasks_lost/reason_task_invalid: 0,
master/tasks_lost/reason_task_unauthorized: 0,
master/tasks_lost/reason_task_unknown: 0,
...
}
and slave:
{
...
slave/tasks_lost: 0,
slave/tasks_lost/reason_executor_terminated: 0,
slave/tasks_lost/reason_executor_unregistered: 0,
slave/tasks_lost/reason_framework_removed: 0,
slave/tasks_lost/reason_gc_error: 0,
slave/tasks_lost/reason_invalid_command: 0,
slave/tasks_lost/reason_invalid_frameworkid: 0,
slave/tasks_lost/reason_invalid_offers: 0,
slave/tasks_lost/reason_master_disconnected: 0,
slave/tasks_lost/reason_memory_limit: 0,
slave/tasks_lost/reason_reconciliation: 0,
slave/tasks_lost/reason_slave_disconnected: 0,
slave/tasks_lost/reason_slave_removed: 0,
slave/tasks_lost/reason_slave_restarted: 0,
slave/tasks_lost/reason_slave_unknown: 0,
slave/tasks_lost/reason_task_invalid: 0,
slave/tasks_lost/reason_task_unauthorized: 0,
slave/tasks_lost/reason_task_unknown: 0,
slave/tasks_running: 0,
slave/tasks_staging: 0,
slave/tasks_starting: 0,
...
}
Thanks,
Dominic Hamon
