----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27557/#review59714 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Nov. 4, 2014, 12:58 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27557/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 12:58 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1941 > https://issues.apache.org/jira/browse/MESOS-1941 > > > Repository: mesos-git > > > Description > ------- > > Pass user into Isolator::prepare. > > Needed by subsequent review on unprivileged child cgroups. > > > Diffs > ----- > > src/slave/containerizer/isolator.hpp > 4c9d1d87b1ae50a54b7b83707c6da7101bd983d3 > src/slave/containerizer/isolator.cpp > 69849d2041bd664f59516fd08e2193181c7b2a50 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 5d43169e9082c7eef6784a435c9bac91e36fc32b > src/slave/containerizer/isolators/cgroups/cpushare.cpp > f9531e447bc2b39ee99d6fb0c8f911a70a3498a3 > src/slave/containerizer/isolators/cgroups/mem.hpp > 25e4afc20563ebc00b70c6e23baf2bbb4854020f > src/slave/containerizer/isolators/cgroups/mem.cpp > 96bc506bb9dce7a455b443d9e24236babe91d890 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > 7cb2ba297ef4de2d1de6b0da94ddc0b889ba1cf7 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 7ed418a8e8c4a0a68715ffb13660e57afeaef69e > src/slave/containerizer/isolators/filesystem/shared.hpp > 75172d5a0929652342d6376358424dccb93389bb > src/slave/containerizer/isolators/filesystem/shared.cpp > 49510b29bdc4f2095140e1155417fd313adc9b82 > src/slave/containerizer/isolators/namespaces/pid.hpp > 7c40e7730e690e69a3bbef02a46ccb32ebc6badf > src/slave/containerizer/isolators/namespaces/pid.cpp > edfb1f64fb535d826886922788d95d0850f49b3e > src/slave/containerizer/isolators/network/port_mapping.hpp > f9215b276459692d0b0097289509854988b70fb9 > src/slave/containerizer/isolators/network/port_mapping.cpp > 14fae1f00050afbc6b99f4aabf868a2d75774b15 > src/slave/containerizer/isolators/posix.hpp > 7e02f92f1b901ec4fad05571a5d3d199624fb535 > src/slave/containerizer/mesos/containerizer.cpp > d4b08f54d6feb453f3a9d27ca54c867176e62102 > src/tests/isolator.hpp d8f3f09cae9c2aabd889ab7625691e6b44b47dba > src/tests/isolator_tests.cpp 4d03f46cbe20c0e7aff15bab0a26d7738b55aab9 > src/tests/port_mapping_tests.cpp 1a5e52c8151e6fa7b55263d41e175f1b0d8238a2 > > Diff: https://reviews.apache.org/r/27557/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
