> On Nov. 3, 2014, 9:59 p.m., Timothy St. Clair wrote: > > src/launcher/fetcher.cpp, line 77 > > <https://reviews.apache.org/r/27483/diff/1/?file=746870#file746870line77> > > > > we should probably bail here, if somehow the return is != 0 (isError() > > || false) > > Ankur Chauhan wrote: > My thinking here was: In case of a user that does not have hadoop_home > set and no hadoop in path, we would like to continue with other methods. If > we bail here for whatever reason (no hadoop, misconfigured hadoop etc), we > would end up breaking the fetcher for all those people. - This holds only if > we assume that hadoop/hdfs is **not** a hard dependency. > > Timothy St. Clair wrote: > We should probably add a comment then to outline the implied > assumption(s).
I have added a comment detailing this. - Ankur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27483/#review59644 ----------------------------------------------------------- On Nov. 4, 2014, 1:04 a.m., Ankur Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27483/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 1:04 a.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1711 > https://issues.apache.org/jira/browse/MESOS-1711 > > > Repository: mesos-git > > > Description > ------- > > Previously, the fetcher used a hardcoded list of schemes to determine what > URIs could be fetched by hadoop (if available). This is now changed such that > we first check if hadoop can fetch them for us and then we fallback to the > os::net and then a local copy method (same as it used to be). This allows > users to fetch artifacts from arbitrary filesystems as long as hadoop is > correctly configured (in core-site.xml). > > > Diffs > ----- > > src/hdfs/hdfs.hpp bbfeddef106c598d8379ced085ef0605c4b2f380 > src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 > > Diff: https://reviews.apache.org/r/27483/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --verbose > support/mesos-style.py > > > Thanks, > > Ankur Chauhan > >
