> On Nov. 4, 2014, 2:05 a.m., Vinod Kone wrote: > > src/tests/isolator_tests.cpp, line 1070 > > <https://reviews.apache.org/r/27558/diff/1/?file=747971#file747971line1070> > > > > maybe a bigger sleep interval to account for slower machines? > > Ian Downes wrote: > The parent is just reading /proc/PID/cgroup which is directly from the > kernel so I think 100 seconds is ample/excessive.
oops didn't realize it was seconds. nm. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27558/#review59713 ----------------------------------------------------------- On Nov. 4, 2014, 1 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27558/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 1 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1941 > https://issues.apache.org/jira/browse/MESOS-1941 > > > Repository: mesos-git > > > Description > ------- > > MesosContainerizer Isolators using cgroups will chown the cgroup to > the executor user, if specified, enabling the executor to create child > cgroups. Cgroup control files are not chowned so the executor cannot > modify its own cgroups, only control files for child cgroups. > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.cpp > f9531e447bc2b39ee99d6fb0c8f911a70a3498a3 > src/slave/containerizer/isolators/cgroups/mem.cpp > 96bc506bb9dce7a455b443d9e24236babe91d890 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 7ed418a8e8c4a0a68715ffb13660e57afeaef69e > src/tests/isolator_tests.cpp 4d03f46cbe20c0e7aff15bab0a26d7738b55aab9 > > Diff: https://reviews.apache.org/r/27558/diff/ > > > Testing > ------- > > # New test added > make check > > > Thanks, > > Ian Downes > >
