> On Nov. 4, 2014, 3:09 a.m., Adam B wrote: > > Ship It!
Following the logic with my internal C++ compiler/interpreter (aka my brain), it's pretty clear that we would have returned earlier in this function if framework were in fact NULL, so the null-check branch is indeed unreachable code. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27567/#review59760 ----------------------------------------------------------- On Nov. 4, 2014, 3:46 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27567/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 3:46 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2038 > https://issues.apache.org/jira/browse/MESOS-2038 > > > Repository: mesos-git > > > Description > ------- > > Removed a few lines of dead code that coverty discovered. > > > Diffs > ----- > > src/slave/slave.cpp 5e9b0e4f93a5100a91340e1f6fb1fe160b2eea4b > > Diff: https://reviews.apache.org/r/27567/diff/ > > > Testing > ------- > > none. > expecting/waiting for review bot to report no problem. > > > Thanks, > > Bernd Mathiske > >
