----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/#review59925 -----------------------------------------------------------
Bad patch! Reviews applied: [27605] Failed command: ./support/apply-review.sh -n -r 27605 Error: 2014-11-05 03:22:17 URL:https://reviews.apache.org/r/27605/diff/raw/ [3414/3414] -> "27605.patch" [1] Successfully applied: Add a unit test to stout path Add a unit test to stout path to increase confidence when changing the code. Review: https://reviews.apache.org/r/27605 Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: stout: 3rdparty/libprocess/3rdparty/stout/Makefile.am 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp libprocess: 3rdparty/libprocess/3rdparty/Makefile.am Failed to commit patch - Mesos ReviewBot On Nov. 5, 2014, 2:53 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27605/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 2:53 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1733 and mesos-1877 > https://issues.apache.org/jira/browse/MESOS-1733 > https://issues.apache.org/jira/browse/mesos-1877 > > > Repository: mesos-git > > > Description > ------- > > Add a unit test to stout path to increase confidence when changing the code. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 0dc2871af7d8c6646080263c71f41db855d50be4 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 7aac3fdb864e838cdd4e0d817ed4dff14923c69d > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > bc6920a24d920c809e36a2a3da1810e52d0db101 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/27605/diff/ > > > Testing > ------- > > make distcheck on Ubuntu 14.04 > > NOTE: ReviewBot is going to be unhappy about this "crossing" stout and > libprocess... I'm not sure what the correct fix for reviewbot is in this > case, since the Makefile does really cross the project bounds... > > > Thanks, > > Cody Maloney > >
