> On Nov. 5, 2014, 4:29 a.m., Tom Arnfeld wrote: > > src/launcher/fetcher.cpp, line 183 > > <https://reviews.apache.org/r/21277/diff/1/?file=577387#file577387line183> > > > > Do you think it would be OK if we could keep support for the > > MESOS_EXECUTOR_URIS environment variable for now, at least for the next > > release or two? > > > > Mainly because the mesos-fetcher tool is actually being uesd by other > > things outside of the mesos slave itself, e.g external containerizers. > > > > Any thoughts?
We could do this but it would increase the overall engineering cost just to postpone some changes that need to happen eventually anyway. JSON seems to be the agreed-upon format going forward. In fact, the general idea behind switching to JSON was that we could be backward-compatible without such problems AFTER MESOS-1248. Anything besides external containerizers that is affected? - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21277/#review59949 ----------------------------------------------------------- On May 9, 2014, 12:05 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21277/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 12:05 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Tom Arnfeld. > > > Bugs: MESOS-1248 > https://issues.apache.org/jira/browse/MESOS-1248 > > > Repository: mesos-git > > > Description > ------- > > See summary (and bug). > > > Diffs > ----- > > src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 > src/slave/fetcher.hpp PRE-CREATION > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21277/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
