Will do!

-- Ankur

> On 5 Nov 2014, at 10:56, Vinod Kone <[email protected]> wrote:
> 
> Good catch. You want to add the log initialization to the main() in
> fetcher.cpp. See master/main.cpp or slave/main.cpp for examples.
> 
> On Wed, Nov 5, 2014 at 10:32 AM, Ankur Chauhan <[email protected]> wrote:
> 
>> I noticed in a run of bin/mesos-tests.sh --gtest_filter=FetcherTest.*:
>> 
>> $ ./bin/mesos-tests.sh --gtest_filter=FetcherTest.*
>> Source directory: /Users/achauhan/Projects/mesos
>> Build directory: /Users/achauhan/Projects/mesos/build
>> -------------------------------------------------------------
>> We cannot run any Docker tests because:
>> Docker tests not supported on non-Linux systems
>> -------------------------------------------------------------
>> Note: Google Test filter =
>> FetcherTest.*-DockerContainerizerTest.ROOT_DOCKER_Launch:DockerContainerizerTest.ROOT_DOCKER_Kill:DockerContainerizerTest.ROOT_DOCKER_Usage:DockerContainerizerTest.DISABLED_ROOT_DOCKER_Recover:DockerContainerizerTest.ROOT_DOCKER_Logs:DockerContainerizerTest.ROOT_DOCKER_Default_CMD:DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Override:DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Args:DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer:DockerContainerizerTest.DISABLED_ROOT_DOCKER_SlaveRecoveryExecutorContainer:DockerContainerizerTest.ROOT_DOCKER_PortMapping:DockerContainerizerTest.ROOT_DOCKER_LaunchSandboxWithColon:DockerTest.ROOT_DOCKER_interface:DockerTest.ROOT_DOCKER_CheckCommandWithShell:DockerTest.ROOT_DOCKER_CheckPortResource:DockerTest.ROOT_DOCKER_CancelPull:SlaveTest.ROOT_RunTaskWithCommandInfoWithoutUser:SlaveTest.DISABLED_ROOT_RunTaskWithCommandInfoWithUser:SlaveCount/Registrar_BENCHMARK_Test.performance/0:SlaveCount/Registrar_BENCHMARK_Test.performance/1:SlaveCount/Registrar_BENCHMARK_Test.performance/2:SlaveCount/Registrar_BENCHMARK_Test.performance/3
>> [==========] Running 4 tests from 1 test case.
>> [----------] Global test environment set-up.
>> [----------] 4 tests from FetcherTest
>> [ RUN      ] FetcherTest.FileURI
>> WARNING: Logging before InitGoogleLogging() is written to STDERR
>> I1104 22:43:38.412901 2068996864 fetcher.cpp:197] Fetching URI
>> 'file:///private/tmp/FetcherTest_FileURI_ipAYlv/from/test'
>> I1104 22:43:38.413653 2068996864 fetcher.cpp:178] Copying resource from
>> '/private/tmp/FetcherTest_FileURI_ipAYlv/from/test' to
>> '/private/tmp/FetcherTest_FileURI_ipAYlv'
>> I1104 22:43:38.419317 2068996864 fetcher.cpp:300] Skipped extracting path
>> '/private/tmp/FetcherTest_FileURI_ipAYlv/test'
>> [       OK ] FetcherTest.FileURI (110 ms)
>> [ RUN      ] FetcherTest.FilePath
>> WARNING: Logging before InitGoogleLogging() is written to STDERR
>> I1104 22:43:38.507416 2068996864 fetcher.cpp:197] Fetching URI
>> '/private/tmp/FetcherTest_FilePath_lAzOZG/from/test'
>> I1104 22:43:38.508020 2068996864 fetcher.cpp:178] Copying resource from
>> '/private/tmp/FetcherTest_FilePath_lAzOZG/from/test' to
>> '/private/tmp/FetcherTest_FilePath_lAzOZG'
>> I1104 22:43:38.512864 2068996864 fetcher.cpp:300] Skipped extracting path
>> '/private/tmp/FetcherTest_FilePath_lAzOZG/test'
>> [       OK ] FetcherTest.FilePath (100 ms)
>> [ RUN      ] FetcherTest.OSNetUriTest
>> WARNING: Logging before InitGoogleLogging() is written to STDERR
>> I1104 22:43:38.608177 2068996864 fetcher.cpp:197] Fetching URI '
>> http://www.example.com/index.html'
>> I1104 22:43:38.608901 2068996864 fetcher.cpp:109] Fetching URI '
>> http://www.example.com/index.html' with os::net
>> I1104 22:43:38.608924 2068996864 fetcher.cpp:119] Downloading '
>> http://www.example.com/index.html' to
>> '/private/tmp/FetcherTest_OSNetUriTest_ZB4nAg/index.html'
>> I1104 22:43:38.619645 2068996864 fetcher.cpp:300] Skipped extracting path
>> '/private/tmp/FetcherTest_OSNetUriTest_ZB4nAg/index.html'
>> [       OK ] FetcherTest.OSNetUriTest (105 ms)
>> [ RUN      ] FetcherTest.FileLocalhostURI
>> WARNING: Logging before InitGoogleLogging() is written to STDERR
>> I1104 22:43:38.712461 2068996864 fetcher.cpp:197] Fetching URI
>> 'file://localhost/private/tmp/FetcherTest_FileLocalhostURI_m1wYnH/from/test'
>> I1104 22:43:38.713353 2068996864 fetcher.cpp:178] Copying resource from
>> '/private/tmp/FetcherTest_FileLocalhostURI_m1wYnH/from/test' to
>> '/private/tmp/FetcherTest_FileLocalhostURI_m1wYnH'
>> I1104 22:43:38.718541 2068996864 fetcher.cpp:300] Skipped extracting path
>> '/private/tmp/FetcherTest_FileLocalhostURI_m1wYnH/test'
>> [       OK ] FetcherTest.FileLocalhostURI (103 ms)
>> [----------] 4 tests from FetcherTest (419 ms total)
>> 
>> [----------] Global test environment tear-down
>> [==========] 4 tests from 1 test case ran. (434 ms total)
>> [  PASSED  ] 4 tests.
>> 
>>  YOU HAVE 5 DISABLED TESTS
>> 
>> There are warnings in the output:
>> 
>> WARNING: Logging before InitGoogleLogging() is written to STDERR
>> And looking at the code, I don't see a glog initialization codeblock.
>> Should there be google::InitGoogleLogging(argv[0]); in the main method? I
>> also cannot figure out how logging is configured in general and/or where
>> mesos-fetcher is invoked. Can someone chime in?
>> 
>> 
>> -- Ankur
>> 

Reply via email to