----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27660/#review60129 -----------------------------------------------------------
I see that none of the processes (master, slave, registrar, etc.) actually check the return value, so they wouldn't know if it failed; and I agree that not including '/' at the start of a route should hard fail. The code changes look shippable to me too. But I'd like to loop in BenH for the final approval, since he originally wrote all this libprocess route code. - Adam B On Nov. 5, 2014, 6:24 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27660/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 6:24 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos-git > > > Description > ------- > > It is an API expectation that the path start with '/', and if it doesn't it > should be a programmer error. > > No code actually checked the return code. If a developer did get this wrong > previously it would silently do nothing and in debugging their endpoint just > wouldn't appear. This makes it simple/easy for them to find. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 81a1f7a3fece78bb7df1e86850572922c8704ea4 > 3rdparty/libprocess/src/process.cpp > 85fb9958342f0bcdde322d9c55333126e6f86668 > > Diff: https://reviews.apache.org/r/27660/diff/ > > > Testing > ------- > > make distcheck on ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
