> On Nov. 7, 2014, 11:25 a.m., Vinod Kone wrote: > > NM. Looks like review bot caught this. Did you forget to run 'make check' ? > > > > Also, before this lands you should send an email to dev list to solicit > > feedback. This is a big change.
i ran make check, i had GTEST_FILTER set. sorry. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review60360 ----------------------------------------------------------- On Nov. 6, 2014, 9:29 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27685/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 9:29 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1143 > https://issues.apache.org/jira/browse/MESOS-1143 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca > src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 > src/tests/master_authorization_tests.cpp > 5ae855e59036c6cbcec15db5449620a8e5b2aa44 > > Diff: https://reviews.apache.org/r/27685/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
