----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27622/#review60617 -----------------------------------------------------------
Patch looks great! Reviews applied: [27516, 27622] All tests passed. - Mesos ReviewBot On Nov. 10, 2014, 4 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27622/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 4 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1248 > https://issues.apache.org/jira/browse/MESOS-1248 > > > Repository: mesos-git > > > Description > ------- > > Rebasing and replacing https://reviews.apache.org/r/21277/. Now dependent on > https://reviews.apache.org/r/27516/ which implements MESOS-1316. > > Replaces the ad-hoc format for env var values that act as fetcher program > comd line args with a JSON format that is gained by translation from protobuf > parsing to a JSON object. > > > Diffs > ----- > > src/launcher/fetcher.cpp 400fadf94d35721cabaa9983b12a5d35f71f5b5b > src/slave/containerizer/fetcher.cpp > a04f0a83f248102ae573dcb6c2f7eb7400589da1 > src/tests/fetcher_tests.cpp a01eec1965900bdc2e706286af56eb034b48018f > > Diff: https://reviews.apache.org/r/27622/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Bernd Mathiske > >
