> On Nov. 10, 2014, 2:38 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 1178 > > <https://reviews.apache.org/r/27831/diff/1/?file=757285#file757285line1178> > > > > Hm.. not sure why 'message' is on the heap in the first place, but we > > can save that for later.
i'm assuming because `sizeof(std::string*) < sizeof(std::string)`, but i agree. also, `unique_ptr` ;) - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27831/#review60694 ----------------------------------------------------------- On Nov. 10, 2014, 2:26 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27831/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 2:26 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: mesos-1694 > https://issues.apache.org/jira/browse/mesos-1694 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf > > Diff: https://reviews.apache.org/r/27831/diff/ > > > Testing > ------- > > make check > ./build/bin/mesos-local.sh > > > Thanks, > > Dominic Hamon > >
