----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27832/#review60712 -----------------------------------------------------------
Patch looks great! Reviews applied: [27832] All tests passed. - Mesos ReviewBot On Nov. 10, 2014, 10:48 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27832/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 10:48 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-2008 > https://issues.apache.org/jira/browse/MESOS-2008 > > > Repository: mesos-git > > > Description > ------- > > The bug here is that since we don't control the scheduler re-registration > retries, it could so happen that scheduler might send more than expected > re-registration (and hence authz) requests causing the expectations to fail. > Paused the clock as a fix. > > > Diffs > ----- > > src/tests/master_authorization_tests.cpp > 5ae855e59036c6cbcec15db5449620a8e5b2aa44 > > Diff: https://reviews.apache.org/r/27832/diff/ > > > Testing > ------- > > make check MESOS_VERBOSE=1 > GTEST_FILTER="*MasterAuthorizationTest.DuplicateReregistration*" > GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 GLOG_v=1 > > > Thanks, > > Vinod Kone > >
