----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27498/#review60852 -----------------------------------------------------------
It would be really helpful if we could put together a sequence chart of what can be going on during settle and what needs to get synchronized 3rdparty/libprocess/include/process/clock.hpp <https://reviews.apache.org/r/27498/#comment102265> Where are you using Nothing()? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/27498/#comment102254> Do you have an example of how that could happen? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27498/#comment102249> s/in actuallity//? - Niklas Nielsen On Nov. 11, 2014, 8:52 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27498/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 8:52 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas > Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/clock.hpp > eb157cac996c48fedc69002b9d80adaba1ed85d1 > 3rdparty/libprocess/include/process/future.hpp > 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf > 3rdparty/libprocess/src/process.cpp > 85fb9958342f0bcdde322d9c55333126e6f86668 > > Diff: https://reviews.apache.org/r/27498/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
