----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27496/#review60911 -----------------------------------------------------------
Hey Ben, would love to help review these. Any chance you could link a ticket in here with the context? And/or update the description on these changes to say a bit more than "See summary"? It's a bit tough to navigate this chain of reviews, as is. For example, I can't easily tell why this particular change is needed. 3rdparty/libprocess/include/process/clock.hpp <https://reviews.apache.org/r/27496/#comment102311> You'll want the include for timer.hpp, much like we include time.hpp but still forward declare it. If one includes *only* clock.hpp, it won't compile unless there is some transitive include of timer.hpp somewhere. We're not so much preventing circular dependencies as we are ensuring that, since there *is* a circular dependency between Clock <-> and Timer, we want to compile regardless of which header is included first. We apply this strategy in killtree.hpp (and other places): killtree.hpp includes os.hpp for children(), process() os.hpp includes killtree.hpp for killtree() 3rdparty/libprocess/include/process/timer.hpp <https://reviews.apache.org/r/27496/#comment102314> Looks like you need an include for clock.hpp..? Does this compile if Clock is not transitively included? - Ben Mahler On Nov. 11, 2014, 4:52 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27496/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 4:52 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas > Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/c++11/delay.hpp > 5f686db1df50829a5aad76eb91ea6a86e8969c1d > 3rdparty/libprocess/include/process/clock.hpp > eb157cac996c48fedc69002b9d80adaba1ed85d1 > 3rdparty/libprocess/include/process/delay.hpp > 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 > 3rdparty/libprocess/include/process/future.hpp > 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf > 3rdparty/libprocess/include/process/timer.hpp > e2f55636b520d43a8c9efa28ad4fe5f75c4f5573 > 3rdparty/libprocess/src/process.cpp > 85fb9958342f0bcdde322d9c55333126e6f86668 > > Diff: https://reviews.apache.org/r/27496/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
