----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27924/#review61484 -----------------------------------------------------------
This will need some more thought, as this breaks the resource accounting in the master. The slave re-registers with tasks and regular executors, which excludes the command executors. It looks like the command executor is special-cased in the containerizer already..? Is that where the containerizers can merge the resources? src/slave/slave.cpp <https://reviews.apache.org/r/27924/#comment103141> - Ben Mahler On Nov. 14, 2014, 7:02 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27924/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 7:02 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1718 > https://issues.apache.org/jira/browse/MESOS-1718 > > > Repository: mesos-git > > > Description > ------- > > Transfer task resources to command executor. > > > Diffs > ----- > > src/slave/slave.hpp d9f9d2e90dd4037f5cd6331c003aafb95b278a01 > src/slave/slave.cpp ba00bf5e4d017fe5d18826a7e484d50ed692d10a > src/tests/slave_recovery_tests.cpp 98e059f33b2b9f552b0a091ded97f78c3b217d45 > src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec > > Diff: https://reviews.apache.org/r/27924/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
