----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27958/#review61569 -----------------------------------------------------------
Ship it! This chain of reviews needs some tests specifically for Socket. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27958/#comment103283> { on newline please. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment103284> Can we put a newline between these two so that it's easy to see that we always return something from this function? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment103285> Newline before this return like in function above please. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment103286> s/string&error/string& failure/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment103289> Any reason not to use onReady here instead of then? You're not actually chaining here and then we could remove the return statement in link_connect_success. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment103288> s/error/failure/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment103290> s/then/onReady/ and then we can make send_connect_success just return void. - Benjamin Hindman On Nov. 14, 2014, 11:19 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27958/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 11:19 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1330 > https://issues.apache.org/jira/browse/MESOS-1330 > > > Repository: mesos-git > > > Description > ------- > > See Summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 66838814236fc064a2463399fb15f4a815879bf5 > 3rdparty/libprocess/src/process.cpp > a34b8702b01dec9c954552de0b923866d172c453 > > Diff: https://reviews.apache.org/r/27958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
