----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27964/#review61579 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27964/#comment103296> s/sendFile/sendfile/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27964/#comment103297> Can we s/_encoder// since that is given by the Encoder argument? Also, now that we're removing send_data and send_file for a single send function that dispatches for Socket::send or Socket::sendfile. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27964/#comment103299> Socket* since this is across an asynchronous boundary again. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27964/#comment103301> Let's just s/result/length/ so we can use it directly. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27964/#comment103302> if (length.isError() || length.isDiscarded()) { 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27964/#comment103303> length.get() - Benjamin Hindman On Nov. 14, 2014, 10:23 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27964/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 10:23 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1330 > https://issues.apache.org/jira/browse/MESOS-1330 > > > Repository: mesos-git > > > Description > ------- > > See Summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 66838814236fc064a2463399fb15f4a815879bf5 > 3rdparty/libprocess/src/process.cpp > a34b8702b01dec9c954552de0b923866d172c453 > > Diff: https://reviews.apache.org/r/27964/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
