----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28090/#review61666 -----------------------------------------------------------
This seems to me like an extension to `find` for ports. If the framework knows which exact ports or range of ports it wants, the `find` behavior works well. If it doesn't care about that then they could use this function to simply as for `N` ports, similar to how they can ask for `N` cpus. It just happens so that `find`'s behavior for cpus is already does that. - Michael Park On Nov. 15, 2014, 7:01 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28090/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 7:01 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > See summary. Frameworks should have their own allocation logics. We shouldn't > embed an allocation logic in mesos interface. > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170 > src/common/resources.cpp e9a0c85 > src/tests/resources_tests.cpp 3e50889 > > Diff: https://reviews.apache.org/r/28090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >