-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28091/
-----------------------------------------------------------

(Updated Nov. 17, 2014, 8:35 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Review comments.


Bugs: MESOS-1974
    https://issues.apache.org/jira/browse/MESOS-1974


Repository: mesos-git


Description
-------

See summary. Always combine Resource objects in Resources and disallow 
invalid/zero Resource objects.


Diffs (updated)
-----

  include/mesos/resources.hpp 0e37170262d3470570a3436b7835bb1d4a121056 
  src/common/resources.cpp e9a0c85dc3748aa635843d98cd5993d5648ec5c2 
  src/examples/low_level_scheduler_libprocess.cpp 
89b43181c9ea012e04018482fb9edd2f8091d63e 
  src/examples/low_level_scheduler_pthread.cpp 
e5cd48a76e201174af1e3a5f45576a342738dceb 
  src/examples/test_framework.cpp e87198bba7c60005d01e6fd58965ac322a3a53e3 
  src/master/drf_sorter.cpp 54649003745721e75e715b9d2e950e1b38f6b9db 
  src/master/hierarchical_allocator_process.hpp 
31dfb2cc86e2e74da43f05fbada10976ce65f3e4 
  src/master/http.cpp 31899334b905f83a2305c51c4bfefbee623e697e 
  src/master/master.cpp 83c2f8a94c00a1b07c5e6ab4e10404e0b3fdf2da 
  src/slave/containerizer/containerizer.cpp 
f234835180b42331f731d92cd2ad7bd56b6efa70 
  src/tests/gc_tests.cpp 8618ae12b337bea19a82dec52455cd19cc735d89 
  src/tests/mesos.hpp c1d64a73ff2312a10d4e809072d219e60c28a76f 
  src/tests/resource_offers_tests.cpp 43820b0a709b6e8643940b70183e277000d4ba35 
  src/tests/resources_tests.cpp 3e50889ff2433930bd137a9d836d0a8bfc2d0388 

Diff: https://reviews.apache.org/r/28091/diff/


Testing
-------

make check


Thanks,

Jie Yu

Reply via email to