----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28088/#review61936 -----------------------------------------------------------
out of curiousity, did you try running clang-format using the .clang-format file in the mesos root? I'd be interested to know how close it gets to your changes. Ideally we would avoid these changes completely by just running clang-format and living with the resuts. - Dominic Hamon On Nov. 17, 2014, 10:43 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28088/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 10:43 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > Style fix. Again, no change to the semantics. > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170262d3470570a3436b7835bb1d4a121056 > src/common/resources.cpp e9a0c85dc3748aa635843d98cd5993d5648ec5c2 > src/tests/resources_tests.cpp 3e50889ff2433930bd137a9d836d0a8bfc2d0388 > > Diff: https://reviews.apache.org/r/28088/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
