----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19176/#review61955 -----------------------------------------------------------
Bad patch! Reviews applied: [19176] Failed command: ./support/apply-review.sh -n -r 19176 Error: 2014-11-18 18:10:59 URL:https://reviews.apache.org/r/19176/diff/raw/ [6933/6933] -> "19176.patch" [1] error: patch failed: src/master/master.hpp:614 error: src/master/master.hpp: patch does not apply error: patch failed: src/master/master.cpp:1009 error: src/master/master.cpp: patch does not apply error: patch failed: src/slave/slave.hpp:103 error: src/slave/slave.hpp: patch does not apply error: patch failed: src/slave/slave.cpp:926 error: src/slave/slave.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 24, 2014, 1:55 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19176/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 1:55 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-905 > https://issues.apache.org/jira/browse/MESOS-905 > > > Repository: mesos-git > > > Description > ------- > > Eliminated the Framework.id FrameworkID field in master and slave, and > replaced each with a Framework.id() accessor that references > Framework.FrameworkInfo.id. > Removed redundant FrameworkID parameters when FrameworkInfo parameters also > exist with valid contained FrameworkID. > Some messages (RunTaskMessage, ExecutorRegisteredMessage) will no longer need > the FrameworkID member, but it is 'required' and cannot be easily deprecated. > Due to rolling upgrades, we must (a) continue to set the FrameworkID in the > messages, in case the recipient is on an older version that needs it; and (b) > merge the FrameworkID into the FrameworkInfo.id, in case we are receiving a > message from an older sender. > > > Diffs > ----- > > src/master/master.hpp f567a43 > src/master/master.cpp 0335b34 > src/slave/slave.hpp 438e5b5 > src/slave/slave.cpp b673fd6 > > Diff: https://reviews.apache.org/r/19176/diff/ > > > Testing > ------- > > make check on ubuntu(Mint14)/gcc4.7.2. > > > Thanks, > > Adam B > >
