> On Nov. 18, 2014, 5:36 p.m., Dominic Hamon wrote: > > src/common/values.cpp, line 559 > > <https://reviews.apache.org/r/28142/diff/1/?file=766660#file766660line559> > > > > is there no test for this?
It will be tested in review 28143. But yeah, we should have a test for that. I'll add one. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28142/#review61945 ----------------------------------------------------------- On Nov. 18, 2014, 1:34 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28142/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 1:34 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/values.cpp c524459134164f34cb97d9961eeff80a70d7214a > > Diff: https://reviews.apache.org/r/28142/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jie Yu > >
