> On Nov. 18, 2014, 7:49 p.m., Vinod Kone wrote: > > src/tests/metrics_tests.cpp, lines 152-153 > > <https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152> > > > > Why start the master? > > Dominic Hamon wrote: > when i didn't, the slave complained that no master could be found and the > test failed. > > Vinod Kone wrote: > that's unexpected. do you know why? > > Dominic Hamon wrote: > cluster.hpp 411: > > CHECK(masters.size() == 1); > > Part of the master detector stuff in cluster called from Slaves::start. > Seems fairly expected to me :)
You can use StartSlave() overload that takes a StandaloneDetector. ``` StandaloneMasterDetector detector; Try<PID<Slave> > slave = StartSlave(&detector); ``` Does that work? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28058/#review61991 ----------------------------------------------------------- On Nov. 18, 2014, 9 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28058/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 9 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2051 > https://issues.apache.org/jira/browse/MESOS-2051 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4 > src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38 > src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a > src/slave/metrics.hpp PRE-CREATION > src/slave/metrics.cpp PRE-CREATION > src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761 > src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f > src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124 > > Diff: https://reviews.apache.org/r/28058/diff/ > > > Testing > ------- > > added new test and ran make check > > > Thanks, > > Dominic Hamon > >
