----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28092/#review62048 -----------------------------------------------------------
I would actually leave these for now given there's nothing to stop anyone from constructing a Resources without validating anyway. In fact, the code you adjusted still performs no validation because it is assumed that the offer's resources are valid, so not sure what we're gaining here. Can we punt on this one? - Ben Mahler On Nov. 17, 2014, 8:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28092/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 8:35 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > Those interfaces are not good because repeated Resource ptr is not validated > (and flattened). > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170262d3470570a3436b7835bb1d4a121056 > src/tests/master_tests.cpp 66423a9dd1bc441ad7207830a87ddff220df2031 > > Diff: https://reviews.apache.org/r/28092/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
